superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] nytai opened a new pull request #11101: style(listview): various changes to get closer to SIP-34 designs.
Date Tue, 29 Sep 2020 20:40:44 GMT

nytai opened a new pull request #11101:
URL: https://github.com/apache/incubator-superset/pull/11101


   ### SUMMARY
   
   <!--- Describe the change below, including rationale and design decisions -->
   - Remove unnecessary scrollbars - vertical and horizontal scrollbars should only appear
when they are required.
   - Table controls should be outside of the white box in the table in the grey area between
the global navigation and the white box on the table.
   - On bulk select: show DELETE as a destructive red button with white text
   - Remove thick grey horizontal line below column headers
   - Remove unnecessary bottom padding on table so the scroll bar goes to the bottom of the
white container
   
   #### Dashboard
   - Make the “Name” column variable width and the other columns fixed width
   - Change the “Published” column with a checkbox to “Status” with either “Published”
or “Draft” for the on/off states
   - Change filter name from “Published” to “Status”
   - Add tooltips for the action icons (Delete, Export, Edit)
   - Move the “Owners” column to second from the right, immediately before Actions
   - Add "+ Dashboard" button
   - “Add [Object]” button in the sub-header should have 16px of margin on the right to
line up with the right edge of the table view’s box 
   
   #### Chart
   - Make “Chart” (name) variable width, all other columns fixed width
   - Add “New Chart” button next to bulk select button (to the right of Bulk Select)
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   I'll take screenshots tomorrow. 😉 
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   👀 
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message