superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] etr2460 opened a new pull request #11099: feat: more specific presto error messages
Date Tue, 29 Sep 2020 04:22:29 GMT

etr2460 opened a new pull request #11099:
URL: https://github.com/apache/incubator-superset/pull/11099


   ### SUMMARY
   Add custom error messages, issue types, and documentation for invalid column and table
errors in Presto. While these are Presto specific error types for now, if we start doing error
message parsing for other db engines, then it might make sense to generalize them in the future.
   
   Designs are from @Steejay's work, please review!
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <img width="1250" alt="Screen Shot 2020-09-28 at 9 18 11 PM" src="https://user-images.githubusercontent.com/7409244/94512226-5ffa5a00-01d0-11eb-9506-df26c4aa5933.png">
   <img width="1250" alt="Screen Shot 2020-09-28 at 9 14 46 PM" src="https://user-images.githubusercontent.com/7409244/94512230-61c41d80-01d0-11eb-85ad-8cba2ca0a1f9.png">
   
   ### TEST PLAN
   Create a chart with an invalid column and see the correct error. Do the same with an invalid
table
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   to: @john-bodley @villebro @graceguo-supercat 
   cc: @Steejay


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message