superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] kgabryje opened a new pull request #10879: ESLint: Enable rule no-named-as-default
Date Thu, 17 Sep 2020 13:05:11 GMT

kgabryje opened a new pull request #10879:
URL: https://github.com/apache/incubator-superset/pull/10879


   ### SUMMARY
   Enable ESLint rule `no-named-as-default`.
   I removed some unused named exports.
   In cases when both default and named exports where used, I renamed default imports with
prefix "Connected" (to point out that it imports a component wrapped in redux's `connect`).
   Finally, there were some variables that had both named and default exports. In such cases
I removed the default export
   
   ### TEST PLAN
   Run `npm run lint` and verify that there are no new linter errors.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message