superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] JasonD28 opened a new pull request #10762: fix: add validator information to email/slack alerts
Date Wed, 02 Sep 2020 05:59:49 GMT

JasonD28 opened a new pull request #10762:
URL: https://github.com/apache/incubator-superset/pull/10762


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   This PR updates alerts by adding the reason why a SQL-based alert was triggered.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Email:
   ![Screen Shot 2020-09-01 at 10 52 25 PM](https://user-images.githubusercontent.com/32852580/91936985-d07f8b00-eca5-11ea-8135-8f760bed7759.png)
   Slack:
   <img width="568" alt="Screen Shot 2020-09-01 at 10 52 47 PM" src="https://user-images.githubusercontent.com/32852580/91937000-dc6b4d00-eca5-11ea-92e8-bd5bf682ce7b.png">
   
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   - [x] local
   - [x] unit test
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message