superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] Leandro-GPIN opened a new pull request #10755: Annotation update when dashboard request
Date Tue, 01 Sep 2020 16:26:38 GMT

Leandro-GPIN opened a new pull request #10755:
URL: https://github.com/apache/incubator-superset/pull/10755


   Removed negation in isDashboardRequest to update dashboard when user select a filter.
   
   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   Fixed issue related the annotation chart. #10713
   
   ### BEFORE/AFTER ANIMATED GIF
   
   #### BEFORE 
   ![annotation_filter_error_slim3](https://user-images.githubusercontent.com/19553149/91877520-773b3b80-ec54-11ea-88dc-a35618ee2b57.gif)
   
   #### AFTER
   ![annotation_filter_fix_slim2](https://user-images.githubusercontent.com/19553149/91877480-68ed1f80-ec54-11ea-9b5b-64e5429bb317.gif)
   
   ### BEFORE/AFTER SCREENSHOTS 
   
   #### BEFORE 
   ![error_annotation1](https://user-images.githubusercontent.com/19553149/91878297-7525ac80-ec55-11ea-80dc-e1d748b07cdb.png)
   
   #### AFTER
   ![fix_annotation1](https://user-images.githubusercontent.com/19553149/91878319-7d7de780-ec55-11ea-8014-4273ea3083f7.png)
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   1. Create a new chart line with region group.
   2. Add the new chart as annotation in Growth Rate chart.
   3. Save as "Growth Rate and Annotation Region".
   4. Select region in Region Filter .
   5. See results in "Growth Rate and Annotation Region".
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: #10713
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message