superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] villebro opened a new pull request #10753: fix(presto): default unknown types to string type
Date Tue, 01 Sep 2020 09:40:18 GMT

villebro opened a new pull request #10753:
URL: https://github.com/apache/incubator-superset/pull/10753


   ### SUMMARY
   A recent PR #10658 introduced a regression on Presto for undefined column types. The regression
was caused due to one of the methods calling the `get_sqla_column_type` method with `None`
which is contradictory with the method signature. This reverts exception raising for unknown
types and defaults those to `sqlalchemy.types.String()`, while at the same time logging the
discrepancy.
   
   Going forward the associated methods need to be broken up and properly unit tested, as
they are currently very difficult to follow.
   
   ### TEST PLAN
   CI + added test
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: closes #10743
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message