superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] eschutho commented on a change in pull request #10916: chore: Moved selectors from class to data-test specific in card_view tests
Date Wed, 30 Sep 2020 18:04:53 GMT

eschutho commented on a change in pull request #10916:
URL: https://github.com/apache/incubator-superset/pull/10916#discussion_r497703010



##########
File path: superset-frontend/src/components/ListView/ListView.tsx
##########
@@ -284,7 +284,10 @@ function ListView<T extends object = any>({
 
   return (
     <ListViewStyles fullHeight={fullHeight}>
-      <div className={`superset-list-view ${className}`}>
+      <div
+        data-test={`${className}`}
+        className={`superset-list-view ${className}`}

Review comment:
       do you want to use the classnames library here?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message