superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] betodealmeida commented on pull request #11098: Add UUID column to ImportMixin
Date Tue, 29 Sep 2020 04:15:04 GMT

betodealmeida commented on pull request #11098:
URL: https://github.com/apache/incubator-superset/pull/11098#issuecomment-700415440


   > Overall looks simpler than I thought it would be. In the interest of minimizing the
number of database migrations, do we want to alter `Dashboard.json_metadata` in the same migration?
   
   I'm not sure... on one hand, doing it in this PR would reduce the number of migrations,
which is great. On the other hand, having PRs with DB migrations being as small as possible
makes it easier to cherry pick them.
   
   Do you have any preferences? I think updating the  column `Dashboard.position_json` to
use UUIDs is simple, but I'm worried about updating the logic that touches it. We'd also have
to update the examples.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message