superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] mistercrunch commented on a change in pull request #11098: Add UUID column to ImportMixin
Date Tue, 29 Sep 2020 03:59:46 GMT

mistercrunch commented on a change in pull request #11098:
URL: https://github.com/apache/incubator-superset/pull/11098#discussion_r496363957



##########
File path: superset/models/helpers.py
##########
@@ -51,6 +53,10 @@ def json_to_dict(json_str: str) -> Dict[Any, Any]:
 
 
 class ImportMixin:
+    uuid = sa.Column(

Review comment:
       Probably out of scope of this PR, but I think we should rename `ImportMixin` to `ExportImportMixin`
eventually




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message