superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #11005: feat: saved query list view + sort/filters
Date Mon, 28 Sep 2020 23:25:12 GMT

codecov-commenter edited a comment on pull request #11005:
URL: https://github.com/apache/incubator-superset/pull/11005#issuecomment-698604719


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=h1)
Report
   > Merging [#11005](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-superset/commit/3a08fd04f3f9ebaaa48fa554028c26062de42f02?el=desc)
will **increase** coverage by `4.06%`.
   > The diff coverage is `85.10%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11005/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11005      +/-   ##
   ==========================================
   + Coverage   61.70%   65.76%   +4.06%     
   ==========================================
     Files         816      816              
     Lines       38586    38634      +48     
     Branches     3650     3655       +5     
   ==========================================
   + Hits        23808    25407    +1599     
   + Misses      14598    13125    -1473     
   + Partials      180      102      -78     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `57.16% <7.89%> (?)` | |
   | #javascript | `62.25% <85.10%> (+0.06%)` | :arrow_up: |
   | #python | `60.96% <ø> (-0.45%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=tree)
| Coverage Δ | |
   |---|---|---|
   | [superset/queries/saved\_queries/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9zYXZlZF9xdWVyaWVzL2FwaS5weQ==)
| `96.22% <ø> (ø)` | |
   | [.../src/views/CRUD/data/savedquery/SavedQueryList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9zYXZlZHF1ZXJ5L1NhdmVkUXVlcnlMaXN0LnRzeA==)
| `87.03% <85.10%> (-12.97%)` | :arrow_down: |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5)
| `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=)
| `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5)
| `97.50% <0.00%> (-2.50%)` | :arrow_down: |
   | [...et-frontend/src/SqlLab/components/LimitControl.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0xpbWl0Q29udHJvbC50c3g=)
| `84.78% <0.00%> (-1.89%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==)
| `81.29% <0.00%> (-0.67%)` | :arrow_down: |
   | [superset/views/base\_api.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZV9hcGkucHk=)
| `97.67% <0.00%> (-0.59%)` | :arrow_down: |
   | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=)
| `88.12% <0.00%> (-0.28%)` | :arrow_down: |
   | [...ontend/src/components/ListView/TableCollection.tsx](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXcvVGFibGVDb2xsZWN0aW9uLnRzeA==)
| `100.00% <0.00%> (ø)` | |
   | ... and [175 more](https://codecov.io/gh/apache/incubator-superset/pull/11005/diff?src=pr&el=tree-more)
| |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=footer).
Last update [3a08fd0...80e36ac](https://codecov.io/gh/apache/incubator-superset/pull/11005?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message