superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] nytai commented on a change in pull request #11005: feat: saved query list view + sort/filters
Date Mon, 28 Sep 2020 21:21:13 GMT

nytai commented on a change in pull request #11005:
URL: https://github.com/apache/incubator-superset/pull/11005#discussion_r496239571



##########
File path: superset-frontend/images/icons/clipboard.svg
##########
@@ -0,0 +1,21 @@
+<!--
+  Licensed to the Apache Software Foundation (ASF) under one
+  or more contributor license agreements.  See the NOTICE file
+  distributed with this work for additional information
+  regarding copyright ownership.  The ASF licenses this file
+  to you under the Apache License, Version 2.0 (the
+  "License"); you may not use this file except in compliance
+  with the License.  You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+  Unless required by applicable law or agreed to in writing,
+  software distributed under the License is distributed on an
+  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+  KIND, either express or implied.  See the License for the
+  specific language governing permissions and limitations
+  under the License.
+-->
+<svg width="18" height="21" viewBox="0 0 18 21" fill="none" xmlns="http://www.w3.org/2000/svg">
+<path fill-rule="evenodd" clip-rule="evenodd" d="M18 7.44C17.9896 7.34813 17.9695 7.25763
17.94 7.17V7.08C17.8919 6.97718 17.8278 6.88267 17.75 6.8L11.75 0.8C11.6673 0.722216 11.5728
0.658081 11.47 0.61C11.4402 0.60576 11.4099 0.60576 11.38 0.61C11.2784 0.551741 11.1662 0.514344
11.05 0.5H7C5.34315 0.5 4 1.84315 4 3.5V4.5H3C1.34315 4.5 0 5.84315 0 7.5V17.5C0 19.1569 1.34315
20.5 3 20.5H11C12.6569 20.5 14 19.1569 14 17.5V16.5H15C16.6569 16.5 18 15.1569 18 13.5V7.5C18
7.5 18 7.5 18 7.44ZM12 3.91L14.59 6.5H13C12.4477 6.5 12 6.05228 12 5.5V3.91ZM12 17.5C12 18.0523
11.5523 18.5 11 18.5H3C2.44772 18.5 2 18.0523 2 17.5V7.5C2 6.94772 2.44772 6.5 3 6.5H4V13.5C4
15.1569 5.34315 16.5 7 16.5H12V17.5ZM16 13.5C16 14.0523 15.5523 14.5 15 14.5H7C6.44772 14.5
6 14.0523 6 13.5V3.5C6 2.94772 6.44772 2.5 7 2.5H10V5.5C10 7.15685 11.3431 8.5 13 8.5H16V13.5Z"
fill="currentColor"/>
+</svg>

Review comment:
       Looks like this file needs to be deleted, as this icon is not called `copy` 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message