superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10914: refactor: table selector on dataset editor
Date Fri, 25 Sep 2020 02:44:50 GMT

codecov-commenter edited a comment on pull request #10914:
URL: https://github.com/apache/incubator-superset/pull/10914#issuecomment-696351607


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10914?src=pr&el=h1)
Report
   > Merging [#10914](https://codecov.io/gh/apache/incubator-superset/pull/10914?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-superset/commit/6181994084067a32883bb01db55356cc7aa4712b?el=desc)
will **increase** coverage by `5.91%`.
   > The diff coverage is `82.42%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10914/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10914?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10914      +/-   ##
   ==========================================
   + Coverage   59.95%   65.86%   +5.91%     
   ==========================================
     Files         782      817      +35     
     Lines       37252    38478    +1226     
     Branches     3350     3638     +288     
   ==========================================
   + Hits        22335    25345    +3010     
   + Misses      14738    13027    -1711     
   + Partials      179      106      -73     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `57.25% <56.88%> (-0.05%)` | :arrow_down: |
   | #javascript | `61.92% <79.91%> (?)` | |
   | #python | `61.39% <ø> (+<0.01%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10914?src=pr&el=tree)
| Coverage Δ | |
   |---|---|---|
   | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10914/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4)
| `56.00% <ø> (+2.00%)` | :arrow_up: |
   | [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10914/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=)
| `71.55% <55.88%> (+29.80%)` | :arrow_up: |
   | [superset-frontend/src/components/TableSelector.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10914/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci50c3g=)
| `82.30% <82.30%> (ø)` | |
   | [...erset-frontend/src/components/DatabaseSelector.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10914/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGF0YWJhc2VTZWxlY3Rvci50c3g=)
| `92.30% <92.30%> (ø)` | |
   | [...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10914/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhc2V0L0FkZERhdGFzZXRNb2RhbC50c3g=)
| `57.57% <100.00%> (+45.57%)` | :arrow_up: |
   | [superset-frontend/src/setup/setupPlugins.ts](https://codecov.io/gh/apache/incubator-superset/pull/10914/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwUGx1Z2lucy50cw==)
| `22.22% <0.00%> (-77.78%)` | :arrow_down: |
   | [superset-frontend/src/views/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10914/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL2luZGV4LnRzeA==)
| `25.00% <0.00%> (-75.00%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10914/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9pbmRleC50c3g=)
| `25.00% <0.00%> (-75.00%)` | :arrow_down: |
   | [superset-frontend/src/views/App.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10914/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0FwcC50c3g=)
| `31.42% <0.00%> (-68.58%)` | :arrow_down: |
   | [...rset-frontend/src/setup/setupErrorMessagesExtra.ts](https://codecov.io/gh/apache/incubator-superset/pull/10914/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3NldHVwL3NldHVwRXJyb3JNZXNzYWdlc0V4dHJhLnRz)
| `50.00% <0.00%> (-50.00%)` | :arrow_down: |
   | ... and [275 more](https://codecov.io/gh/apache/incubator-superset/pull/10914/diff?src=pr&el=tree-more)
| |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10914?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10914?src=pr&el=footer).
Last update [6181994...2dfb192](https://codecov.io/gh/apache/incubator-superset/pull/10914?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message