superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] bkyryliuk commented on pull request #10963: feat: enable ETag header for dashboard GET requests
Date Thu, 24 Sep 2020 01:21:14 GMT

bkyryliuk commented on pull request #10963:
URL: https://github.com/apache/incubator-superset/pull/10963#issuecomment-698055692


   > response to client-side, with eTag header, last_modified header and expiration time
header. last_modified time is max of (dashboard' changed_on and its slices change
   
   great thanks, it looks like it addresses question #1, what about 2 and 3? 
   
   e.g. for #2 
   * if chart was cached for ~10 hours and etag cached the dashboard, does it mean that chart
on this dashboard will be cached for 10 hours + etag expiration time ? 
   for #3 
   * how it will affect dashboard / datasource changes like annotations, changed to the default
filters, css rules, etc would those changes be cached for the user as well?
   
   Sorry if those questions do not make sense or are obvious. I am just trying to understand
the flow here


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message