superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] kkucharc commented on a change in pull request #10909: fix: several disabled pylint rules in models/helpers.py
Date Fri, 18 Sep 2020 14:20:23 GMT

kkucharc commented on a change in pull request #10909:
URL: https://github.com/apache/incubator-superset/pull/10909#discussion_r490983093



##########
File path: superset/models/helpers.py
##########
@@ -424,7 +425,10 @@ class ExtraJSONMixin:
     def extra(self) -> Dict[str, Any]:
         try:
             return json.loads(self.extra_json)
-        except Exception:  # pylint: disable=broad-except
+        except (TypeError, JSONDecodeError) as exc:
+            logger.error(
+                "Unable to load an extra json: %r. Leaving empty.", exc, exc_info=True

Review comment:
       @dpgaspar do you mind to take a look again? I have one doubt: do you think is it possible
there could be raised exception while accessing `self.extra_json` for logger?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message