superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10594: [WIP] - Dashboard access permissions
Date Fri, 18 Sep 2020 03:51:20 GMT

codecov-commenter edited a comment on pull request #10594:
URL: https://github.com/apache/incubator-superset/pull/10594#issuecomment-673445076


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10594?src=pr&el=h1)
Report
   > Merging [#10594](https://codecov.io/gh/apache/incubator-superset/pull/10594?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-superset/commit/141ef4a188698efb595cd5f5da402c148d9207bf?el=desc)
will **decrease** coverage by `4.76%`.
   > The diff coverage is `56.38%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10594/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10594?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10594      +/-   ##
   ==========================================
   - Coverage   65.88%   61.11%   -4.77%     
   ==========================================
     Files         815      383     -432     
     Lines       38337    24310   -14027     
     Branches     3601        0    -3601     
   ==========================================
   - Hits        25257    14858   -10399     
   + Misses      12978     9452    -3526     
   + Partials      102        0     -102     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `61.11% <56.38%> (-0.36%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10594?src=pr&el=tree)
| Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5)
| `90.42% <ø> (ø)` | |
   | [superset/dashbaord\_level\_access\_initializer.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJhb3JkX2xldmVsX2FjY2Vzc19pbml0aWFsaXplci5weQ==)
| `0.00% <0.00%> (ø)` | |
   | [superset/cli.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5)
| `39.67% <20.00%> (-0.33%)` | :arrow_down: |
   | [superset/dashboards/security.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9zZWN1cml0eS5weQ==)
| `56.36% <56.36%> (ø)` | |
   | [superset/dashboards/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9maWx0ZXJzLnB5)
| `76.59% <56.52%> (-19.96%)` | :arrow_down: |
   | [superset/dashboards/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9idWxrX2RlbGV0ZS5weQ==)
| `86.48% <60.00%> (-4.43%)` | :arrow_down: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==)
| `74.16% <60.00%> (-0.31%)` | :arrow_down: |
   | [superset/security/manager.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc2VjdXJpdHkvbWFuYWdlci5weQ==)
| `86.86% <66.07%> (-4.16%)` | :arrow_down: |
   | [superset/dashboards/commands/create.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9jcmVhdGUucHk=)
| `90.47% <66.66%> (-1.84%)` | :arrow_down: |
   | [superset/dashboards/commands/delete.py](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9jb21tYW5kcy9kZWxldGUucHk=)
| `88.88% <66.66%> (-2.03%)` | :arrow_down: |
   | ... and [451 more](https://codecov.io/gh/apache/incubator-superset/pull/10594/diff?src=pr&el=tree-more)
| |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10594?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10594?src=pr&el=footer).
Last update [141ef4a...a02c699](https://codecov.io/gh/apache/incubator-superset/pull/10594?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message