superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] bkyryliuk commented on a change in pull request #10836: feat: Stop pending queries when user close dashboard
Date Thu, 17 Sep 2020 02:25:56 GMT

bkyryliuk commented on a change in pull request #10836:
URL: https://github.com/apache/incubator-superset/pull/10836#discussion_r489891167



##########
File path: superset/db_engine_specs/base.py
##########
@@ -1001,3 +1001,13 @@ def get_extra_params(database: "Database") -> Dict[str, Any]:
                 logger.error(ex)
                 raise ex
         return extra
+
+    @classmethod
+    def stop_queries(cls, username: str, dashboard_id: int) -> None:

Review comment:
       curious if there is an interest to have in in superset as well e.g. use smth like:
   ```CALL system.runtime.kill_query('20151207_215727_00146_tx3nr');```
   https://github.com/prestodb/presto/issues/1515
   
   However a challenge here would be tracking all queries and there ids




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message