superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] riahk commented on a change in pull request #10922: feat: update saved query backend routing + add savedquery list
Date Wed, 16 Sep 2020 23:11:20 GMT

riahk commented on a change in pull request #10922:
URL: https://github.com/apache/incubator-superset/pull/10922#discussion_r489802911



##########
File path: superset-frontend/src/views/CRUD/data/common.ts
##########
@@ -36,8 +36,8 @@ export const commonMenuData = {
     {
       name: 'Saved Queries',
       label: t('Saved Queries'),
-      url: '/sqllab/my_queries/',
-      usesRouter: false,
+      url: '/savedqueryview/list/',
+      usesRouter: true,

Review comment:
       Turns out it does not, I think I misunderstood how we were using the feature flags.
In which case the new Databases view feature flag also got broken with my last routing update




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message