superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] kkucharc commented on a change in pull request #10909: Fixed several disabled pylint rules in models/helpers.py
Date Wed, 16 Sep 2020 13:20:54 GMT

kkucharc commented on a change in pull request #10909:
URL: https://github.com/apache/incubator-superset/pull/10909#discussion_r489431211



##########
File path: superset/models/helpers.py
##########
@@ -66,14 +63,6 @@ class ImportMixin:
     # The names of the attributes
     # that are available for import and export
 
-    @classmethod

Review comment:
       @willbarrett I am really interested in your opinion about this change. I assume this
method is private because:
   - it might change in future, or
   - it's supposed to be used only in `ImportMixin` class.
   But since this method is used on other instances (not only `cls`) I suggested making it
public. WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message