superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] akelai edited a comment on issue #10708: URLs that are generated e.g. on tabs, to be copy-pasted elsewhere, have "127.0.0.1:8088" instead of the actual address to reach the Superset application
Date Wed, 16 Sep 2020 10:53:40 GMT

akelai edited a comment on issue #10708:
URL: https://github.com/apache/incubator-superset/issues/10708#issuecomment-693295999


   Update: I noticed that the "Share Query" button in SQL Lab doesn't have this problem, i.e.
it works fine, generating the share URL with the actual domain.
   
   Is it possible to have the same (working) behavior for all the share URLs that can be generated
in Superset?
   
   Maybe it has something to do with the fact that for the "Share Query" button in SQL Lab
there is code like this:
   ```
   savedQueryToastContent = `${window.location.origin + window.location.pathname}?savedQueryId=${this.props.queryEditor.remoteId}`;
   ```
   ...while in other places there is code like this:
   ```
   url: window.location.href.substring(window.location.origin.length)
   ```
   ?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message