superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] mistercrunch commented on a change in pull request #10854: doc(style): Update docs mobile layout, links for docs and readmes
Date Tue, 15 Sep 2020 23:21:36 GMT

mistercrunch commented on a change in pull request #10854:
URL: https://github.com/apache/incubator-superset/pull/10854#discussion_r489068228



##########
File path: README.md
##########
@@ -71,24 +74,45 @@ A modern, enterprise-ready business intelligence web application.
 ## Why Superset
 
 Superset provides:
-* An intuitive interface to explore and visualize datasets, and
-    create interactive dashboards.
-* A wide array of beautiful visualizations to showcase your data.
-* Easy, code-free, user flows to drill down and slice and dice the data
-    underlying exposed dashboards. The dashboards and charts act as a starting
-    point for deeper analysis.
-* A state of the art SQL editor/IDE exposing a rich metadata browser, and
-    an easy workflow to create visualizations out of any result set.
-* An extensible, high granularity security model allowing intricate rules
-    on who can access which product features and datasets.
-    Integration with major
-    authentication backends (database, OpenID, LDAP, OAuth, REMOTE_USER, ...)
-* A lightweight semantic layer, allowing to control how data sources are
-    exposed to the user by defining dimensions and metrics
-* Out of the box support for most SQL-speaking databases
-* Deep integration with Druid allows for Superset to stay blazing fast while
-    slicing and dicing large, realtime datasets
-* Fast loading dashboards with configurable caching
+
+Viewed
+
+A modern, enterprise-ready business intelligence web application.	Apache Superset (Incubating)
is a modern, 
+enterprise-ready business intelligence web application. It is fast, lightweight, intuitive,

+and loaded with options that make it easy for users of all skill sets to explore and visualize

+their data, from simple pie charts to highly detailed deck.gl geospatial charts.
+
+[**Why Superset**](#why-superset) |	[**Why Superset**](#why-superset) |
+[**Supported Databases**](#supported-databases) |	[**Supported Databases**](#supported-databases)
|
+
+## Why Superset	## Why Superset

Review comment:
       this looks wrong

##########
File path: README.md
##########
@@ -71,24 +74,45 @@ A modern, enterprise-ready business intelligence web application.
 ## Why Superset
 
 Superset provides:
-* An intuitive interface to explore and visualize datasets, and
-    create interactive dashboards.
-* A wide array of beautiful visualizations to showcase your data.
-* Easy, code-free, user flows to drill down and slice and dice the data
-    underlying exposed dashboards. The dashboards and charts act as a starting
-    point for deeper analysis.
-* A state of the art SQL editor/IDE exposing a rich metadata browser, and
-    an easy workflow to create visualizations out of any result set.
-* An extensible, high granularity security model allowing intricate rules
-    on who can access which product features and datasets.
-    Integration with major
-    authentication backends (database, OpenID, LDAP, OAuth, REMOTE_USER, ...)
-* A lightweight semantic layer, allowing to control how data sources are
-    exposed to the user by defining dimensions and metrics
-* Out of the box support for most SQL-speaking databases
-* Deep integration with Druid allows for Superset to stay blazing fast while
-    slicing and dicing large, realtime datasets
-* Fast loading dashboards with configurable caching
+
+Viewed
+
+A modern, enterprise-ready business intelligence web application.	Apache Superset (Incubating)
is a modern, 
+enterprise-ready business intelligence web application. It is fast, lightweight, intuitive,

+and loaded with options that make it easy for users of all skill sets to explore and visualize

+their data, from simple pie charts to highly detailed deck.gl geospatial charts.
+
+[**Why Superset**](#why-superset) |	[**Why Superset**](#why-superset) |
+[**Supported Databases**](#supported-databases) |	[**Supported Databases**](#supported-databases)
|
+
+## Why Superset	## Why Superset
+
+Superset provides:	Superset provides:

Review comment:
       odd doubles, wondering what happened here. I highly recommend doing a first sanity
pass on your PR when opening the PR on the step prior to "Create PR"




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message