superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10745: feat: add/edit database modal form sections UI
Date Thu, 10 Sep 2020 01:53:30 GMT

codecov-commenter edited a comment on pull request #10745:
URL: https://github.com/apache/incubator-superset/pull/10745#issuecomment-686127303


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10745?src=pr&el=h1)
Report
   > Merging [#10745](https://codecov.io/gh/apache/incubator-superset/pull/10745?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-superset/commit/e4ffaecc72afb706a31d66d626e3c15c94b3a995?el=desc)
will **decrease** coverage by `4.16%`.
   > The diff coverage is `48.46%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10745/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10745?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #10745      +/-   ##
   ==========================================
   - Coverage   65.49%   61.33%   -4.17%     
   ==========================================
     Files         803      803              
     Lines       37931    38044     +113     
     Branches     3561     3605      +44     
   ==========================================
   - Hits        24843    23334    -1509     
   - Misses      12982    14524    +1542     
   - Partials      106      186      +80     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `61.59% <48.46%> (+<0.01%)` | :arrow_up: |
   | #python | `61.18% <ø> (-0.01%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment)
to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10745?src=pr&el=tree)
| Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/common/components/Modal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10745/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL01vZGFsLnRzeA==)
| `93.75% <ø> (ø)` | |
   | [superset-frontend/src/common/components/Tabs.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10745/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL1RhYnMudHN4)
| `100.00% <ø> (+40.00%)` | :arrow_up: |
   | [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/incubator-superset/pull/10745/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==)
| `94.73% <ø> (ø)` | |
   | [superset-frontend/src/views/CRUD/hooks.ts](https://codecov.io/gh/apache/incubator-superset/pull/10745/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvaG9va3MudHM=)
| `68.53% <45.16%> (-24.57%)` | :arrow_down: |
   | [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10745/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==)
| `60.76% <49.43%> (+7.06%)` | :arrow_up: |
   | [...tend/src/views/CRUD/data/database/DatabaseList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10745/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZUxpc3QudHN4)
| `82.05% <50.00%> (-4.91%)` | :arrow_down: |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10745/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4)
| `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10745/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==)
| `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10745/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4)
| `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10745/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4)
| `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [166 more](https://codecov.io/gh/apache/incubator-superset/pull/10745/diff?src=pr&el=tree-more)
| |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10745?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10745?src=pr&el=footer).
Last update [e4ffaec...fa434ad](https://codecov.io/gh/apache/incubator-superset/pull/10745?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message