superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] etr2460 commented on a change in pull request #10740: chore: Simple Eslint cleanup ✨
Date Wed, 09 Sep 2020 15:04:08 GMT

etr2460 commented on a change in pull request #10740:
URL: https://github.com/apache/incubator-superset/pull/10740#discussion_r485684671



##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -163,7 +163,8 @@ export default class FilterableTable extends PureComponent<
   }
 
   componentDidMount() {
-    this.fitTableToWidthIfNeeded();
+    if (this.container.current)

Review comment:
       since this is already on 2 lines, maybe we should add the braces around it anyway?
   
   I've been meaning to look into why this isn't enforced by our lint setup currently: https://github.com/airbnb/javascript#blocks--braces




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message