superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] dpgaspar commented on a change in pull request #10774: fix: pivot table timestamp grouping
Date Thu, 03 Sep 2020 13:30:13 GMT

dpgaspar commented on a change in pull request #10774:
URL: https://github.com/apache/incubator-superset/pull/10774#discussion_r482978425



##########
File path: superset/viz.py
##########
@@ -856,6 +856,30 @@ def get_aggfunc(
         # only min and max work properly for non-numerics
         return aggfunc if aggfunc in ("min", "max") else "max"
 
+    @staticmethod
+    def _format_datetime(value: Any) -> Any:

Review comment:
       nit: `def _format_datetime(value: Union[pd.Timestamp, datetime, date, str]) -> Union[pd.Timestamp,
datetime, date, str]:`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message