superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] rusackas commented on a change in pull request #10740: Simple Eslint cleanup ✨
Date Tue, 01 Sep 2020 15:54:59 GMT

rusackas commented on a change in pull request #10740:
URL: https://github.com/apache/incubator-superset/pull/10740#discussion_r481249117



##########
File path: superset-frontend/src/components/FilterableTable/FilterableTable.tsx
##########
@@ -290,7 +290,7 @@ export default class FilterableTable extends PureComponent<
   }
 
   fitTableToWidthIfNeeded() {
-    const containerWidth = this.container.current!.clientWidth;
+    const containerWidth = this.container?.current?.clientWidth ?? 0;

Review comment:
       Just kidding... what I did caused another TS error that my IDE didn't catch. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message