superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] villebro commented on a change in pull request #10753: fix(presto): default unknown types to string type
Date Tue, 01 Sep 2020 09:42:23 GMT

villebro commented on a change in pull request #10753:
URL: https://github.com/apache/incubator-superset/pull/10753#discussion_r481007000



##########
File path: superset/db_engine_specs/presto.py
##########
@@ -174,7 +174,9 @@ def get_view_names(
         return [row[0] for row in results]
 
     @classmethod
-    def _create_column_info(cls, name: str, data_type: str) -> Dict[str, Any]:
+    def _create_column_info(
+        cls, name: str, data_type: types.TypeEngine
+    ) -> Dict[str, Any]:

Review comment:
       Not sure why MyPy hadn't picked up on the calls sending `TypeEngine` to `data_type`,
not `str`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message