From notifications-return-45406-archive-asf-public=cust-asf.ponee.io@superset.apache.org Wed Jul 1 05:58:16 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 16FD1180638 for ; Wed, 1 Jul 2020 07:58:15 +0200 (CEST) Received: (qmail 44850 invoked by uid 500); 1 Jul 2020 05:58:15 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 44826 invoked by uid 99); 1 Jul 2020 05:58:15 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jul 2020 05:58:15 +0000 From: =?utf-8?q?GitBox?= To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_codecov-commenter_commented_?= =?utf-8?q?on_pull_request_=2310208=3A_feat=3A_support_nulls_in_the_csv_uplo?= =?utf-8?q?ads_=5BWIP=5D?= Message-ID: <159358309521.29655.6005637517978783900.asfpy@gitbox.apache.org> Date: Wed, 01 Jul 2020 05:58:15 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: codecov-commenter commented on pull request #10208: URL: https://github.com/apache/incubator-superset/pull/10208#issuecomment-652209012 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10208?src=pr&el=h1) Report > Merging [#10208](https://codecov.io/gh/apache/incubator-superset/pull/10208?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/b686004294326f69a8aa8e587881a4747d110f0d&el=desc) will **increase** coverage by `0.14%`. > The diff coverage is `100.00%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/10208/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/10208?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #10208 +/- ## ========================================== + Coverage 70.25% 70.40% +0.14% ========================================== Files 594 594 Lines 31498 31524 +26 Branches 3223 3223 ========================================== + Hits 22129 22193 +64 + Misses 9254 9223 -31 + Partials 115 108 -7 ``` | Flag | Coverage Δ | | |---|---|---| | #cypress | `52.95% <ø> (+0.15%)` | :arrow_up: | | #javascript | `59.42% <ø> (-0.01%)` | :arrow_down: | | #python | `70.23% <100.00%> (+0.10%)` | :arrow_up: | | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10208?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/10208/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `90.07% <100.00%> (+0.07%)` | :arrow_up: | | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/10208/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `86.80% <100.00%> (+0.03%)` | :arrow_up: | | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/10208/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `50.82% <100.00%> (+2.34%)` | :arrow_up: | | [superset/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10208/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZm9ybXMucHk=) | `96.96% <100.00%> (+1.51%)` | :arrow_up: | | [superset/views/database/forms.py](https://codecov.io/gh/apache/incubator-superset/pull/10208/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvZm9ybXMucHk=) | `91.48% <100.00%> (+0.79%)` | :arrow_up: | | [superset/views/database/views.py](https://codecov.io/gh/apache/incubator-superset/pull/10208/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2Uvdmlld3MucHk=) | `91.05% <100.00%> (+0.45%)` | :arrow_up: | | [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/10208/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: | | [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10208/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: | | [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10208/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `77.27% <0.00%> (-3.90%)` | :arrow_down: | | [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10208/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: | | ... and [21 more](https://codecov.io/gh/apache/incubator-superset/pull/10208/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10208?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10208?src=pr&el=footer). Last update [b686004...3e3927c](https://codecov.io/gh/apache/incubator-superset/pull/10208?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org