From notifications-return-41505-archive-asf-public=cust-asf.ponee.io@superset.apache.org Tue May 19 23:32:43 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3A80F180638 for ; Wed, 20 May 2020 01:32:43 +0200 (CEST) Received: (qmail 21093 invoked by uid 500); 19 May 2020 23:32:42 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 21079 invoked by uid 99); 19 May 2020 23:32:42 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 May 2020 23:32:42 +0000 From: =?utf-8?q?GitBox?= To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_codecov-commenter_edited_a_c?= =?utf-8?q?omment_on_pull_request_=239628=3A_feat=3A_upgrade_react-select_an?= =?utf-8?q?d_make_multi-select_sortable?= Message-ID: <158993116250.19379.8070618751720994310.asfpy@gitbox.apache.org> Date: Tue, 19 May 2020 23:32:42 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: codecov-commenter edited a comment on pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#issuecomment-631141430 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=h1) Report > Merging [#9628](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/68832d2fa50ad18f4523b8ffb50dc8976ccdc2ec&el=desc) will **decrease** coverage by `5.02%`. > The diff coverage is `65.19%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9628/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #9628 +/- ## ========================================== - Coverage 71.02% 65.99% -5.03% ========================================== Files 583 589 +6 Lines 30615 30614 -1 Branches 3162 3241 +79 ========================================== - Hits 21745 20205 -1540 - Misses 8759 10222 +1463 - Partials 111 187 +76 ``` | Flag | Coverage Δ | | |---|---|---| | #cypress | `?` | | | #javascript | `59.28% <65.19%> (-0.02%)` | :arrow_down: | | #python | `70.79% <ø> (-0.48%)` | :arrow_down: | | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [...set-frontend/src/SqlLab/components/QuerySearch.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1F1ZXJ5U2VhcmNoLmpzeA==) | `57.54% <ø> (ø)` | | | [...perset-frontend/src/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `72.72% <ø> (ø)` | | | [superset-frontend/src/components/AsyncSelect.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QuanN4) | `96.29% <ø> (ø)` | | | [superset-frontend/src/components/ColumnOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29sdW1uT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | | | [...uperset-frontend/src/components/ExpandableList.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXhwYW5kYWJsZUxpc3QudHN4) | `88.88% <ø> (ø)` | | | [superset-frontend/src/components/MetricOption.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | | | [superset-frontend/src/components/TableSelector.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVGFibGVTZWxlY3Rvci5qc3g=) | `82.67% <0.00%> (-0.91%)` | :arrow_down: | | [...et-frontend/src/dashboard/components/CssEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Nzc0VkaXRvci5qc3g=) | `68.18% <ø> (ø)` | | | [.../src/dashboard/components/RefreshIntervalModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1JlZnJlc2hJbnRlcnZhbE1vZGFsLmpzeA==) | `100.00% <ø> (ø)` | | | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==) | `79.66% <ø> (-1.70%)` | :arrow_down: | | ... and [229 more](https://codecov.io/gh/apache/incubator-superset/pull/9628/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=footer). Last update [68832d2...3bfabac](https://codecov.io/gh/apache/incubator-superset/pull/9628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org