From notifications-return-41226-archive-asf-public=cust-asf.ponee.io@superset.apache.org Mon May 18 19:48:46 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7745718062B for ; Mon, 18 May 2020 21:48:46 +0200 (CEST) Received: (qmail 69171 invoked by uid 500); 18 May 2020 19:48:45 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 69162 invoked by uid 99); 18 May 2020 19:48:45 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 May 2020 19:48:45 +0000 From: =?utf-8?q?GitBox?= To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_rusackas_commented_on_a_chan?= =?utf-8?q?ge_in_pull_request_=239768=3A_feat=3A_partitionchart_controls_mig?= =?utf-8?q?ration?= Message-ID: <158983132577.19379.11966217962704557077.asfpy@gitbox.apache.org> Date: Mon, 18 May 2020 19:48:45 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: rusackas commented on a change in pull request #9768: URL: https://github.com/apache/incubator-superset/pull/9768#discussion_r426736914 ########## File path: superset-frontend/spec/javascripts/components/ColumnOption_spec.jsx ########## @@ -19,9 +19,9 @@ import React from 'react'; import { shallow } from 'enzyme'; -import ColumnOption from 'src/components/ColumnOption'; -import ColumnTypeLabel from 'src/components/ColumnTypeLabel'; -import InfoTooltipWithTrigger from 'src/components/InfoTooltipWithTrigger'; +import { InfoTooltipWithTrigger } from '@superset-ui/control-utils'; +import ColumnOption from '../../../src/components/ColumnOption'; +import ColumnTypeLabel from '../../../src/components/ColumnTypeLabel'; Review comment: These still seem to be the relative paths... I think that's all that's holding this up. ########## File path: superset-frontend/spec/javascripts/components/FormRow_spec.jsx ########## @@ -19,10 +19,10 @@ import React from 'react'; import { shallow } from 'enzyme'; +import { InfoTooltipWithTrigger } from '@superset-ui/control-utils'; import { Col, Row } from 'react-bootstrap'; -import TextControl from 'src/explore/components/controls/TextControl'; -import InfoTooltipWithTrigger from 'src/components/InfoTooltipWithTrigger'; -import FormRow from 'src/components/FormRow'; +import TextControl from '../../../src/explore/components/controls/TextControl'; +import FormRow from '../../../src/components/FormRow'; Review comment: paths issue here too... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org