From notifications-return-40906-archive-asf-public=cust-asf.ponee.io@superset.apache.org Thu May 14 23:41:05 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3D2C0180675 for ; Fri, 15 May 2020 01:41:05 +0200 (CEST) Received: (qmail 15531 invoked by uid 500); 14 May 2020 23:41:04 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 15522 invoked by uid 99); 14 May 2020 23:41:04 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 May 2020 23:41:04 +0000 From: =?utf-8?q?GitBox?= To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_ktmud_commented_on_a_change_?= =?utf-8?q?in_pull_request_=239628=3A_feat=3A_upgrade_react-select_and_make_?= =?utf-8?q?multi-select_sortable?= Message-ID: <158949966447.19379.6372323172426257347.asfpy@gitbox.apache.org> Date: Thu, 14 May 2020 23:41:04 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: ktmud commented on a change in pull request #9628: URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425488309 ########## File path: superset-frontend/src/components/AsyncSelect.jsx ########## @@ -18,7 +18,8 @@ */ import React from 'react'; import PropTypes from 'prop-types'; -import Select from 'react-select'; +// TODO: refactor this with `import { AsyncSelect } from src/components/Select` Review comment: This component handles its own async logics, which doesn't seem necessary and is kind of confusing (we probably don't want two ways of doing AsyncSelect). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org