From notifications-return-40536-archive-asf-public=cust-asf.ponee.io@superset.apache.org Thu May 7 15:29:03 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 584C618062B for ; Thu, 7 May 2020 17:29:03 +0200 (CEST) Received: (qmail 51052 invoked by uid 500); 7 May 2020 15:29:02 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 51043 invoked by uid 99); 7 May 2020 15:29:02 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 May 2020 15:29:02 +0000 From: =?utf-8?q?GitBox?= To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_etr2460_commented_on_a_chang?= =?utf-8?q?e_in_pull_request_=239714=3A_fix_bug_where_error_at_import_dashbo?= =?utf-8?q?ard_fails_to_show_toast_in_=22welcome=22_app?= Message-ID: <158886534266.26397.3194719877520961880.asfpy@gitbox.apache.org> Date: Thu, 07 May 2020 15:29:02 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: etr2460 commented on a change in pull request #9714: URL: https://github.com/apache/incubator-superset/pull/9714#discussion_r421591922 ########## File path: superset-frontend/src/components/FlashProvider.tsx ########## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React from 'react'; +import withToasts from 'src/messageToasts/enhancers/withToasts'; + +type Message = Array; + +interface CommonObject { + flash_messages: Array; +} +interface Props { + children: Node; + common: CommonObject; +} + +const flashObj = { + info: 'addInfoToast', + danger: 'addDangerToast', + warning: 'addWarningToast', + success: 'addSuccessToast', +}; + +class FlashProvider extends React.PureComponent { + componentDidMount() { + const flashArr = this.props.common.flash_messages; Review comment: naming nit: `flashMessages` seems like a better name ########## File path: superset-frontend/src/components/FlashProvider.tsx ########## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React from 'react'; +import withToasts from 'src/messageToasts/enhancers/withToasts'; + +type Message = Array; + +interface CommonObject { + flash_messages: Array; +} +interface Props { + children: Node; + common: CommonObject; +} + +const flashObj = { + info: 'addInfoToast', + danger: 'addDangerToast', + warning: 'addWarningToast', + success: 'addSuccessToast', +}; + +class FlashProvider extends React.PureComponent { + componentDidMount() { + const flashArr = this.props.common.flash_messages; + if (flashArr.length > 0) { + flashArr.forEach((item, i) => { Review comment: naming nit: `message` is a bit more descriptive than `item` ########## File path: superset-frontend/src/components/FlashProvider.tsx ########## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React from 'react'; +import withToasts from 'src/messageToasts/enhancers/withToasts'; + +type Message = Array; + +interface CommonObject { + flash_messages: Array; +} +interface Props { + children: Node; + common: CommonObject; +} + +const flashObj = { + info: 'addInfoToast', + danger: 'addDangerToast', + warning: 'addWarningToast', + success: 'addSuccessToast', +}; + +class FlashProvider extends React.PureComponent { + componentDidMount() { + const flashArr = this.props.common.flash_messages; + if (flashArr.length > 0) { Review comment: we don't need this since the forEach loop won't be entered if length is 0 ########## File path: superset-frontend/src/components/FlashProvider.tsx ########## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React from 'react'; +import withToasts from 'src/messageToasts/enhancers/withToasts'; + +type Message = Array; + +interface CommonObject { + flash_messages: Array; +} +interface Props { + children: Node; + common: CommonObject; +} + +const flashObj = { + info: 'addInfoToast', + danger: 'addDangerToast', + warning: 'addWarningToast', + success: 'addSuccessToast', +}; + +class FlashProvider extends React.PureComponent { + componentDidMount() { + const flashArr = this.props.common.flash_messages; + if (flashArr.length > 0) { + flashArr.forEach((item, i) => { Review comment: `i` is unused so we can get rid of it ########## File path: superset-frontend/src/components/FlashProvider.tsx ########## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +import React from 'react'; +import withToasts from 'src/messageToasts/enhancers/withToasts'; + +type Message = Array; + +interface CommonObject { + flash_messages: Array; +} +interface Props { + children: Node; + common: CommonObject; +} + +const flashObj = { + info: 'addInfoToast', + danger: 'addDangerToast', + warning: 'addWarningToast', + success: 'addSuccessToast', +}; + +class FlashProvider extends React.PureComponent { + componentDidMount() { + const flashArr = this.props.common.flash_messages; + if (flashArr.length > 0) { + flashArr.forEach((item, i) => { + const type = item[0]; + const text = item[1]; Review comment: nit: this could be `const [type, text] = item;` I believe ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org