From notifications-return-40509-archive-asf-public=cust-asf.ponee.io@superset.apache.org Thu May 7 02:15:52 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id DA942180665 for ; Thu, 7 May 2020 04:15:51 +0200 (CEST) Received: (qmail 11514 invoked by uid 500); 7 May 2020 02:15:51 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 11501 invoked by uid 99); 7 May 2020 02:15:51 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 07 May 2020 02:15:51 +0000 From: =?utf-8?q?GitBox?= To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_john-bodley_commented_on_a_c?= =?utf-8?q?hange_in_pull_request_=239753=3A_feat=3A_convert_backend_chart_er?= =?utf-8?q?rors_to_the_new_error_type?= Message-ID: <158881775119.26397.11627693289953701216.asfpy@gitbox.apache.org> Date: Thu, 07 May 2020 02:15:51 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: john-bodley commented on a change in pull request #9753: URL: https://github.com/apache/incubator-superset/pull/9753#discussion_r421198521 ########## File path: superset/models/helpers.py ########## @@ -374,13 +374,20 @@ class QueryResult: # pylint: disable=too-few-public-methods """Object returned by the query interface""" def __init__( # pylint: disable=too-many-arguments - self, df, query, duration, status=QueryStatus.SUCCESS, error_message=None + self, + df, + query, + duration, + status=QueryStatus.SUCCESS, + error_message=None, + errors=None, ): self.df: pd.DataFrame = df self.query: str = query self.duration: int = duration self.status: str = status self.error_message: Optional[str] = error_message + self.errors: Optional[List[Dict[str, Any]]] = errors Review comment: @etr2460 sorry this could be: ```python self.errors: List[Dict[str, Any]] = errors or [] ``` which simplifies the related content in `viz.py`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org