From notifications-return-40225-apmail-superset-notifications-archive=superset.apache.org@superset.apache.org Mon May 4 16:44:15 2020 Return-Path: X-Original-To: apmail-superset-notifications-archive@minotaur.apache.org Delivered-To: apmail-superset-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 4F64219EAF for ; Mon, 4 May 2020 16:44:15 +0000 (UTC) Received: (qmail 66160 invoked by uid 500); 4 May 2020 16:44:14 -0000 Delivered-To: apmail-superset-notifications-archive@superset.apache.org Received: (qmail 66142 invoked by uid 500); 4 May 2020 16:44:14 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 66132 invoked by uid 99); 4 May 2020 16:44:14 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 04 May 2020 16:44:14 +0000 From: =?utf-8?q?GitBox?= To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_codecov-io_commented_on_pull?= =?utf-8?q?_request_=239714=3A_fix_bug_where_error_at_import_dashboard_fails?= =?utf-8?q?_to_show_toast_in_=22welcome=22_app?= Message-ID: <158861065472.26397.18267200057334633447.asfpy@gitbox.apache.org> Date: Mon, 04 May 2020 16:44:14 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: codecov-io commented on pull request #9714: URL: https://github.com/apache/incubator-superset/pull/9714#issuecomment-623575770 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9714?src=pr&el=h1) Report > Merging [#9714](https://codecov.io/gh/apache/incubator-superset/pull/9714?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/5d167afb9499d7ce30c7ea763b19993af347dc23&el=desc) will **decrease** coverage by `0.05%`. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9714/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9714?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #9714 +/- ## ========================================== - Coverage 70.72% 70.66% -0.06% ========================================== Files 584 182 -402 Lines 30382 17818 -12564 Branches 3112 0 -3112 ========================================== - Hits 21487 12591 -8896 + Misses 8781 5227 -3554 + Partials 114 0 -114 ``` | Flag | Coverage Δ | | |---|---|---| | #cypress | `?` | | | #javascript | `?` | | | #python | `70.66% <ø> (-0.22%)` | :arrow_down: | | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9714?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/views/database/mixins.py](https://codecov.io/gh/apache/incubator-superset/pull/9714/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `58.92% <0.00%> (-21.43%)` | :arrow_down: | | [superset/utils/cache.py](https://codecov.io/gh/apache/incubator-superset/pull/9714/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2FjaGUucHk=) | `45.83% <0.00%> (-20.84%)` | :arrow_down: | | [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/9714/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `78.26% <0.00%> (-13.05%)` | :arrow_down: | | [superset/views/database/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9714/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvYXBpLnB5) | `83.90% <0.00%> (-3.45%)` | :arrow_down: | | [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/incubator-superset/pull/9714/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `97.29% <0.00%> (-2.71%)` | :arrow_down: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9714/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.47% <0.00%> (-2.39%)` | :arrow_down: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/9714/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.90% <0.00%> (-0.23%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9714/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `88.41% <0.00%> (-0.16%)` | :arrow_down: | | [...ntend/src/dashboard/components/PropertiesModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9714/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1Byb3BlcnRpZXNNb2RhbC5qc3g=) | | | | [superset-frontend/src/components/AnchorLink.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9714/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQW5jaG9yTGluay5qc3g=) | | | | ... and [398 more](https://codecov.io/gh/apache/incubator-superset/pull/9714/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9714?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9714?src=pr&el=footer). Last update [5d167af...02cc383](https://codecov.io/gh/apache/incubator-superset/pull/9714?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org