From notifications-return-40153-apmail-superset-notifications-archive=superset.apache.org@superset.apache.org Fri May 1 19:47:25 2020 Return-Path: X-Original-To: apmail-superset-notifications-archive@minotaur.apache.org Delivered-To: apmail-superset-notifications-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 657E619CBF for ; Fri, 1 May 2020 19:47:25 +0000 (UTC) Received: (qmail 16162 invoked by uid 500); 1 May 2020 19:47:25 -0000 Delivered-To: apmail-superset-notifications-archive@superset.apache.org Received: (qmail 16144 invoked by uid 500); 1 May 2020 19:47:24 -0000 Mailing-List: contact notifications-help@superset.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@superset.apache.org Delivered-To: mailing list notifications@superset.apache.org Received: (qmail 16133 invoked by uid 99); 1 May 2020 19:47:24 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 01 May 2020 19:47:24 +0000 From: =?utf-8?q?GitBox?= To: notifications@superset.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-superset=5D_nytai_commented_on_pull_requ?= =?utf-8?q?est_=239692=3A_=5Bsqllab=5D_fix=2C_strip_comments_before_parsing_?= =?utf-8?q?statements?= Message-ID: <158836244483.26397.16853266143569406014.asfpy@gitbox.apache.org> Date: Fri, 01 May 2020 19:47:24 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: nytai commented on pull request #9692: URL: https://github.com/apache/incubator-superset/pull/9692#issuecomment-622536056 Additionally `sqlparse` doesn't seem to tag comments. The type it's resolving `-- some comment` to is `'UNKNOWN'`. We could add `UNKNOWN` to the `is_readonly` check, but that seems less safe than strictly treating only `SELECT|EXPLAIN` as readonly ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org For additional commands, e-mail: notifications-help@superset.apache.org