superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] villebro opened a new pull request #9762: fix: implement force refresh in chart data request
Date Thu, 07 May 2020 08:54:01 GMT

villebro opened a new pull request #9762:
URL: https://github.com/apache/incubator-superset/pull/9762


   ### CATEGORY
   
   Choose one
   
   - [x] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   With the introduction of the new chart data API, support for force updating charts was
temporarily lost. This updates the `@superset-ui/chart` and `@superset-ui/query` packages
which recently added support for force updates ( https://github.com/apache-superset/superset-ui/pull/445
) and adds the `force` property to `formData`, which is now properly deserialized by the new
endpoint ( #9749 ).
   
   ### BEFORE
   ![word-cloud-before](https://user-images.githubusercontent.com/33317356/81274158-96381100-9058-11ea-89f8-a595de2c7cd7.gif)
   
   ### AFTER
   ![word-cloud-after](https://user-images.githubusercontent.com/33317356/81274212-a819b400-9058-11ea-8109-6f1eb6053cb1.gif)
   
   ### TEST PLAN
   Local testing
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: #9187 
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   @suddjian @rusackas @kristw @ktmud 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message