superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] ktmud opened a new pull request #9761: test(frontend): use absolute path for src imports
Date Thu, 07 May 2020 07:52:48 GMT

ktmud opened a new pull request #9761:
URL: https://github.com/apache/incubator-superset/pull/9761


   ### CATEGORY
   
   - [x] Refactor
   - [x] Build / Development Environment
   
   ### SUMMARY
   
   This changes all JS imports in `specs` to use absolute path, which shall make rearranging
the test files easier.
   
   Added a `jsconfig.json` for VS Code so that intellisense can still work.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   N/A
   
   ### TEST PLAN
   
   Make sure CI passes and other IDEs also have no problem using JS features.
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   
   @kristw @evans @villebro 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message