superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] etr2460 opened a new pull request #9753: feat: convert backend chart errors to the new error type
Date Wed, 06 May 2020 16:52:15 GMT

etr2460 opened a new pull request #9753:
URL: https://github.com/apache/incubator-superset/pull/9753


   ### CATEGORY
   
   Choose one
   
   - [ ] Bug Fix
   - [x] Enhancement (new features, refinement)
   - [x] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   Continuing to implement SIP-40, this time adding some of the backend logic. My plan is
as follows:
   - Start replacing the `error` field in api responses with the `errors` list of SupersetError
Objects
   - Support backwards compatibility on the frontend by pulling the message out of the `errors`
list into the `error` field again
   - Provide the necessary info to the front end to render better error messages once designs
are ready
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   No ui changes
   
   ### TEST PLAN
   Test dashboards loading with and without errors in charts, see errors still render properly
   Test SQL Lab with and without query errors
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   to: @john-bodley @villebro @dpgaspar 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message