superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] dpgaspar opened a new pull request #9752: fix(mssql): CAST with AT produces statements with syntax errors
Date Wed, 06 May 2020 14:51:35 GMT

dpgaspar opened a new pull request #9752:
URL: https://github.com/apache/incubator-superset/pull/9752


   ### CATEGORY
   
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   On SQLLAb executing SQL statements with `CAST` and `AT` fail. This is a partial fix, since
this seems to open up a bigger problem `sqlparse` does dot correctly identify columns with
`CAST(FOO_COL AS TYPEX) AT TIME ZONE 'Eastern Standard Time'` for example, and just adds `CAST(FOO_OLD
AS TYPEX)` on the IdentifierList.
   
   This is a partial fix, since it will discard `CAST` from the alias setting, so that we
don't double alias it. Yet it means that all `CAST` statements need to have an Alias.
   
   ### ADDITIONAL INFORMATION
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   ### REVIEWERS
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message