superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] serenajiang opened a new pull request #9716: [hive][csv upload] make INTs BIGINTs
Date Sat, 02 May 2020 04:38:15 GMT

serenajiang opened a new pull request #9716:
URL: https://github.com/apache/incubator-superset/pull/9716


   ### CATEGORY
   
   Choose one
   
   - [X] Bug Fix
   - [ ] Enhancement (new features, refinement)
   - [ ] Refactor
   - [ ] Add tests
   - [ ] Build / Development Environment
   - [ ] Documentation
   
   ### SUMMARY
   When uploading a csv to Hive, all integer columns are created as INT, which causes integers
greater than `2147483647` to appear `null`. This is not great if there are ids greater than
a few billion.
   
   We could probably be more specific and identify whether to use TINYINT, INT, BIGINT, DOUBLE,
STRING, etc so that we don't top out at $2^63 - 1$, but that's for another time.
   
   ### TEST PLAN
   Test on devbox.
   
   ### REVIEWERS
   @john-bodley @etr2460 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message