superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] codecov-io edited a comment on pull request #9819: feat(frontend): add ability to download dashboard and chart as image
Date Sun, 17 May 2020 06:14:26 GMT

codecov-io edited a comment on pull request #9819:
URL: https://github.com/apache/incubator-superset/pull/9819#issuecomment-629682732


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9819?src=pr&el=h1)
Report
   > Merging [#9819](https://codecov.io/gh/apache/incubator-superset/pull/9819?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-superset/commit/ea9b7f2dc426cf912f8f5f2b749cc707c9af6964&el=desc)
will **increase** coverage by `4.70%`.
   > The diff coverage is `50.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9819/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9819?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9819      +/-   ##
   ==========================================
   + Coverage   66.16%   70.87%   +4.70%     
   ==========================================
     Files         585      586       +1     
     Lines       30427    30450      +23     
     Branches     3152     3158       +6     
   ==========================================
   + Hits        20133    21580    +1447     
   + Misses      10113     8759    -1354     
   + Partials      181      111      -70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.59% <40.00%> (?)` | |
   | #javascript | `59.24% <50.00%> (-0.02%)` | :arrow_down: |
   | #python | `71.02% <ø> (-0.01%)` | :arrow_down: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9819?src=pr&el=tree)
| Coverage Δ | |
   |---|---|---|
   | [...d/src/dashboard/components/SliceHeaderControls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9819/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NsaWNlSGVhZGVyQ29udHJvbHMuanN4)
| `67.44% <ø> (+55.81%)` | :arrow_up: |
   | [...set-frontend/src/dashboard/util/downloadAsImage.ts](https://codecov.io/gh/apache/incubator-superset/pull/9819/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2Rvd25sb2FkQXNJbWFnZS50cw==)
| `43.75% <43.75%> (ø)` | |
   | [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9819/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=)
| `79.16% <100.00%> (+9.60%)` | :arrow_up: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9819/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5)
| `71.91% <0.00%> (-0.10%)` | :arrow_down: |
   | [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/9819/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4)
| `56.98% <0.00%> (+1.07%)` | :arrow_up: |
   | [superset-frontend/src/components/EditableTitle.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9819/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRWRpdGFibGVUaXRsZS5qc3g=)
| `81.69% <0.00%> (+1.40%)` | :arrow_up: |
   | [...perset-frontend/src/components/CopyToClipboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9819/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ29weVRvQ2xpcGJvYXJkLmpzeA==)
| `36.36% <0.00%> (+1.51%)` | :arrow_up: |
   | [...hboard/components/resizable/ResizableContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9819/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVDb250YWluZXIuanN4)
| `71.87% <0.00%> (+1.56%)` | :arrow_up: |
   | [...ashboard/components/gridComponents/ChartHolder.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9819/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0SG9sZGVyLmpzeA==)
| `81.35% <0.00%> (+1.69%)` | :arrow_up: |
   | ... and [140 more](https://codecov.io/gh/apache/incubator-superset/pull/9819/diff?src=pr&el=tree-more)
| |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9819?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9819?src=pr&el=footer).
Last update [ea9b7f2...c3edfe7](https://codecov.io/gh/apache/incubator-superset/pull/9819?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message