superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable
Date Fri, 15 May 2020 00:51:13 GMT

ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425507511



##########
File path: superset-frontend/src/components/Select/styles.tsx
##########
@@ -0,0 +1,299 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React, { CSSProperties } from 'react';
+import { css, SerializedStyles } from '@emotion/core';
+import { supersetTheme } from '@superset-ui/style';
+import {
+  Styles,
+  Theme,
+  SelectComponentsConfig,
+  components as defaultComponents,
+} from 'react-select';
+import { colors as reactSelectColros } from 'react-select/src/theme';
+import { supersetColors } from 'src/components/styles';
+
+export const DEFAULT_CLASS_NAME = 'Select';
+export const DEFAULT_CLASS_NAME_PREFIX = 'Select';
+
+type RecursivePartial<T> = {
+  [P in keyof T]?: RecursivePartial<T[P]>;
+};
+
+export type ThemeConfig = {
+  borderRadius: number;
+  // z-index for menu dropdown
+  // (the same as `@z-index-above-dashboard-charts + 1` in variables.less)
+  zIndex: number;
+  colors: {
+    // add known colors
+    [key in keyof typeof reactSelectColros]: string;
+  } &
+    {
+      [key in keyof typeof supersetColors]: string;
+    } & {
+      [key: string]: string; // any other colors
+    };
+  spacing: Theme['spacing'] & {
+    // line height and font size must be pixels for easier computation
+    // of option item height in WindowedMenuList
+    lineHeight: number;
+    fontSize: number;
+    // other relative size must be string
+    minWidth: string;
+  };
+};
+
+export type PartialThemeConfig = RecursivePartial<ThemeConfig>;
+
+export const DEFAULT_THEME: PartialThemeConfig = {
+  borderRadius: parseInt(supersetTheme.borderRadius, 10),
+  zIndex: 11,

Review comment:
       Yes, this number `11` was obtained from `variables.less` (there is a note in the type
definition above). I don't know how to make a variable accessible to both less and styled
components, so I just added the CSS variable name for reference. In the future, we might want
to refactor all these to real CSS variables.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message