ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425494501
##########
File path: superset-frontend/src/components/ListView/Filters.tsx
##########
@@ -37,13 +44,21 @@ interface SelectFilterProps extends BaseFilter {
const FilterContainer = styled.div`
display: inline-flex;
- margin-right: 8px;
+ margin-right: 1.2em;
Review comment:
Personal preference. When the spacing should scale according to font sizes, it makes
more sense to use `em`s.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
|