superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] ktmud commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable
Date Thu, 14 May 2020 23:41:04 GMT

ktmud commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r425488309



##########
File path: superset-frontend/src/components/AsyncSelect.jsx
##########
@@ -18,7 +18,8 @@
  */
 import React from 'react';
 import PropTypes from 'prop-types';
-import Select from 'react-select';
+// TODO: refactor this with `import { AsyncSelect } from src/components/Select`

Review comment:
       This component handles its own async logics, which doesn't seem necessary and is kind
of confusing (we probably don't want two ways of doing AsyncSelect).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message