superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] nytai commented on a change in pull request #9628: feat: upgrade react-select and make multi-select sortable
Date Wed, 13 May 2020 20:33:10 GMT

nytai commented on a change in pull request #9628:
URL: https://github.com/apache/incubator-superset/pull/9628#discussion_r424714108



##########
File path: superset-frontend/src/components/ListView/LegacyFilters.tsx
##########
@@ -67,9 +63,10 @@ export const FilterMenu = ({
           <MenuItem
             key={ft.id}
             eventKey={ft}
-            onSelect={(fltr: typeof ft) =>
-              setInternalFilters([...internalFilters, fltr])
-            }
+            // @ts-ignore

Review comment:
       Yes, this is old code that's going to be killed soon. I think react-bootstrap was missing
proper typings when this was being implemented so some type is probably being overridden incorrectly.
 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message