superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] codecov-io edited a comment on pull request #9753: feat: convert backend chart errors to the new error type
Date Fri, 08 May 2020 18:03:03 GMT

codecov-io edited a comment on pull request #9753:
URL: https://github.com/apache/incubator-superset/pull/9753#issuecomment-624795472


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9753?src=pr&el=h1)
Report
   > Merging [#9753](https://codecov.io/gh/apache/incubator-superset/pull/9753?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-superset/commit/3a213916c47073abb8168c485c72c3d439e152a8&el=desc)
will **decrease** coverage by `0.00%`.
   > The diff coverage is `75.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9753/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9753?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9753      +/-   ##
   ==========================================
   - Coverage   70.81%   70.81%   -0.01%     
   ==========================================
     Files         586      587       +1     
     Lines       30442    30476      +34     
     Branches     3120     3121       +1     
   ==========================================
   + Hits        21558    21582      +24     
   - Misses       8770     8780      +10     
     Partials      114      114              
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.62% <0.00%> (-0.11%)` | :arrow_down: |
   | #javascript | `59.09% <100.00%> (+0.02%)` | :arrow_up: |
   | #python | `70.95% <74.00%> (+0.01%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9753?src=pr&el=tree)
| Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==)
| `66.66% <ø> (ø)` | |
   | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz)
| `100.00% <ø> (+100.00%)` | :arrow_up: |
   | [superset/viz\_sip38.py](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6X3NpcDM4LnB5)
| `0.00% <0.00%> (ø)` | |
   | [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==)
| `93.33% <50.00%> (ø)` | |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5)
| `71.44% <50.00%> (-0.06%)` | :arrow_down: |
   | [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz)
| `83.33% <100.00%> (+1.19%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==)
| `88.56% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=)
| `87.96% <100.00%> (+0.17%)` | :arrow_up: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5)
| `100.00% <100.00%> (ø)` | |
   | [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=)
| `87.95% <100.00%> (+0.06%)` | :arrow_up: |
   | ... and [6 more](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree-more)
| |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9753?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9753?src=pr&el=footer).
Last update [3a21391...316a1db](https://codecov.io/gh/apache/incubator-superset/pull/9753?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message