superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] dpgaspar commented on pull request #9752: fix(mssql): CAST with AT produces statements with syntax errors
Date Thu, 07 May 2020 22:45:18 GMT

dpgaspar commented on pull request #9752:
URL: https://github.com/apache/incubator-superset/pull/9752#issuecomment-625534249


   Yes I know and totally agree @mistercrunch bad initial approach on my side.
   
   @bkyryliuk catching the error may be a good approach, could turn out to be difficult to
pin the engine error, specific to non aliased functions, on the other hand, it's also a bit
hard to parse the query and search for non aliased functions. So I may give it a try


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message