superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] bkyryliuk commented on pull request #9752: fix(mssql): CAST with AT produces statements with syntax errors
Date Thu, 07 May 2020 18:44:42 GMT

bkyryliuk commented on pull request #9752:
URL: https://github.com/apache/incubator-superset/pull/9752#issuecomment-625430874


   I like the approach, and eventually it would be nice to have that logic in the db specific
engines.
   I briefly looked into explain and it doesn't look promising, https://docs.microsoft.com/en-us/sql/t-sql/queries/explain-transact-sql?view=azure-sqldw-latest
   
   Another potential alternative could be to catch an error and make it more user friendly
e.g. stating that all columns should be aliased. It would make user experience slightly worse
in the beginning, but over time should not be an issue and may be slightly easier to implement.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message