superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] kristw commented on a change in pull request #9761: test(frontend): use absolute path for src imports
Date Thu, 07 May 2020 16:57:24 GMT

kristw commented on a change in pull request #9761:
URL: https://github.com/apache/incubator-superset/pull/9761#discussion_r421653438



##########
File path: superset-frontend/.prettierrc
##########
@@ -1,4 +1,5 @@
 {
   "singleQuote": true,
-  "trailingComma": "all"
+  "trailingComma": "all",
+  "arrowParens": "avoid"

Review comment:
       There seems to be another change to space between `function` and parentheses.
   
   `function() {}` vs `function () {}`
   
   I do not have strong preference in terms of styling but perhaps we can use the original
to reduce amount of changes. 
   
   This is the settings from `@superset-ui`
   
   ```ts
   {
     "arrowParens": "avoid",
     "bracketSpacing": true,
     "jsxBracketSameLine": false,
     "printWidth": 100,
     "proseWrap": "always",
     "requirePragma": false,
     "semi": true,
     "singleQuote": true,
     "tabWidth": 2,
     "trailingComma": "all",
     "useTabs": false
   };
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message