superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] etr2460 commented on a change in pull request #9714: fix bug where error at import dashboard fails to show toast in "welcome" app
Date Thu, 07 May 2020 15:29:02 GMT

etr2460 commented on a change in pull request #9714:
URL: https://github.com/apache/incubator-superset/pull/9714#discussion_r421591922



##########
File path: superset-frontend/src/components/FlashProvider.tsx
##########
@@ -0,0 +1,56 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+
+type Message = Array<string>;
+
+interface CommonObject {
+  flash_messages: Array<Message>;
+}
+interface Props {
+  children: Node;
+  common: CommonObject;
+}
+
+const flashObj = {
+  info: 'addInfoToast',
+  danger: 'addDangerToast',
+  warning: 'addWarningToast',
+  success: 'addSuccessToast',
+};
+
+class FlashProvider extends React.PureComponent<Props> {
+  componentDidMount() {
+    const flashArr = this.props.common.flash_messages;

Review comment:
       naming nit: `flashMessages` seems like a better name

##########
File path: superset-frontend/src/components/FlashProvider.tsx
##########
@@ -0,0 +1,56 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+
+type Message = Array<string>;
+
+interface CommonObject {
+  flash_messages: Array<Message>;
+}
+interface Props {
+  children: Node;
+  common: CommonObject;
+}
+
+const flashObj = {
+  info: 'addInfoToast',
+  danger: 'addDangerToast',
+  warning: 'addWarningToast',
+  success: 'addSuccessToast',
+};
+
+class FlashProvider extends React.PureComponent<Props> {
+  componentDidMount() {
+    const flashArr = this.props.common.flash_messages;
+    if (flashArr.length > 0) {
+      flashArr.forEach((item, i) => {

Review comment:
       naming nit: `message` is a bit more descriptive than `item`

##########
File path: superset-frontend/src/components/FlashProvider.tsx
##########
@@ -0,0 +1,56 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+
+type Message = Array<string>;
+
+interface CommonObject {
+  flash_messages: Array<Message>;
+}
+interface Props {
+  children: Node;
+  common: CommonObject;
+}
+
+const flashObj = {
+  info: 'addInfoToast',
+  danger: 'addDangerToast',
+  warning: 'addWarningToast',
+  success: 'addSuccessToast',
+};
+
+class FlashProvider extends React.PureComponent<Props> {
+  componentDidMount() {
+    const flashArr = this.props.common.flash_messages;
+    if (flashArr.length > 0) {

Review comment:
       we don't need this since the forEach loop won't be entered if length is 0

##########
File path: superset-frontend/src/components/FlashProvider.tsx
##########
@@ -0,0 +1,56 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+
+type Message = Array<string>;
+
+interface CommonObject {
+  flash_messages: Array<Message>;
+}
+interface Props {
+  children: Node;
+  common: CommonObject;
+}
+
+const flashObj = {
+  info: 'addInfoToast',
+  danger: 'addDangerToast',
+  warning: 'addWarningToast',
+  success: 'addSuccessToast',
+};
+
+class FlashProvider extends React.PureComponent<Props> {
+  componentDidMount() {
+    const flashArr = this.props.common.flash_messages;
+    if (flashArr.length > 0) {
+      flashArr.forEach((item, i) => {

Review comment:
       `i` is unused so we can get rid of it

##########
File path: superset-frontend/src/components/FlashProvider.tsx
##########
@@ -0,0 +1,56 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import React from 'react';
+import withToasts from 'src/messageToasts/enhancers/withToasts';
+
+type Message = Array<string>;
+
+interface CommonObject {
+  flash_messages: Array<Message>;
+}
+interface Props {
+  children: Node;
+  common: CommonObject;
+}
+
+const flashObj = {
+  info: 'addInfoToast',
+  danger: 'addDangerToast',
+  warning: 'addWarningToast',
+  success: 'addSuccessToast',
+};
+
+class FlashProvider extends React.PureComponent<Props> {
+  componentDidMount() {
+    const flashArr = this.props.common.flash_messages;
+    if (flashArr.length > 0) {
+      flashArr.forEach((item, i) => {
+        const type = item[0];
+        const text = item[1];

Review comment:
       nit: this could be `const [type, text] = item;` I believe




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message