superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] codecov-io edited a comment on pull request #9756: Fix SQL Lab schema permission checks
Date Wed, 06 May 2020 22:42:35 GMT 

codecov-io edited a comment on pull request #9756:
URL: https://github.com/apache/incubator-superset/pull/9756#issuecomment-624850795


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9756?src=pr&el=h1)
Report
   > Merging [#9756](https://codecov.io/gh/apache/incubator-superset/pull/9756?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-superset/commit/865a9096906c5c564d86c422fc3bd35e9a3444bd&el=desc)
will **decrease** coverage by `4.61%`.
   > The diff coverage is `91.26%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9756/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9756?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9756      +/-   ##
   ==========================================
   - Coverage   70.49%   65.88%   -4.62%     
   ==========================================
     Files         402      586     +184     
     Lines       12564    30434   +17870     
     Branches     3112     3117       +5     
   ==========================================
   + Hits         8857    20050   +11193     
   - Misses       3593    10200    +6607     
   - Partials      114      184      +70     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `59.02% <71.87%> (+0.11%)` | :arrow_up: |
   | #python | `70.71% <100.00%> (?)` | |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9756?src=pr&el=tree)
| Coverage Δ | |
   |---|---|---|
   | [...erset-frontend/src/dashboard/components/Header.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9756/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlci5qc3g=)
| `41.79% <ø> (-14.93%)` | :arrow_down: |
   | [...src/dashboard/components/HeaderActionsDropdown.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9756/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0hlYWRlckFjdGlvbnNEcm9wZG93bi5qc3g=)
| `69.56% <ø> (-8.70%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/components/SaveModal.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9756/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL1NhdmVNb2RhbC5qc3g=)
| `43.90% <ø> (-39.03%)` | :arrow_down: |
   | [...ntend/src/dashboard/containers/DashboardHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9756/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb250YWluZXJzL0Rhc2hib2FyZEhlYWRlci5qc3g=)
| `100.00% <ø> (ø)` | |
   | [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9756/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4)
| `51.19% <ø> (-30.96%)` | :arrow_down: |
   | [superset/datasets/api.py](https://codecov.io/gh/apache/incubator-superset/pull/9756/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5)
| `92.56% <ø> (ø)` | |
   | [...et-frontend/src/dashboard/components/Dashboard.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9756/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL0Rhc2hib2FyZC5qc3g=)
| `75.32% <35.71%> (-13.74%)` | :arrow_down: |
   | [...et-frontend/src/dashboard/util/isDashboardEmpty.ts](https://codecov.io/gh/apache/incubator-superset/pull/9756/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2lzRGFzaGJvYXJkRW1wdHkudHM=)
| `100.00% <100.00%> (ø)` | |
   | [superset-frontend/src/explore/AdhocFilter.js](https://codecov.io/gh/apache/incubator-superset/pull/9756/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQWRob2NGaWx0ZXIuanM=)
| `93.15% <100.00%> (-2.74%)` | :arrow_down: |
   | [...ponents/AdhocFilterEditPopoverSimpleTabContent.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9756/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9BZGhvY0ZpbHRlckVkaXRQb3BvdmVyU2ltcGxlVGFiQ29udGVudC5qc3g=)
| `81.10% <100.00%> (-7.09%)` | :arrow_down: |
   | ... and [342 more](https://codecov.io/gh/apache/incubator-superset/pull/9756/diff?src=pr&el=tree-more)
| |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9756?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9756?src=pr&el=footer).
Last update [865a909...18d2967](https://codecov.io/gh/apache/incubator-superset/pull/9756?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Mime
View raw message