superset-notifications mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-superset] codecov-io edited a comment on pull request #9753: feat: convert backend chart errors to the new error type
Date Wed, 06 May 2020 17:53:08 GMT

codecov-io edited a comment on pull request #9753:
URL: https://github.com/apache/incubator-superset/pull/9753#issuecomment-624795472


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9753?src=pr&el=h1)
Report
   > Merging [#9753](https://codecov.io/gh/apache/incubator-superset/pull/9753?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-superset/commit/5d167afb9499d7ce30c7ea763b19993af347dc23&el=desc)
will **increase** coverage by `0.09%`.
   > The diff coverage is `88.63%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/9753/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/9753?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #9753      +/-   ##
   ==========================================
   + Coverage   70.72%   70.81%   +0.09%     
   ==========================================
     Files         584      587       +3     
     Lines       30382    30470      +88     
     Branches     3112     3118       +6     
   ==========================================
   + Hits        21487    21577      +90     
   + Misses       8781     8780       -1     
   + Partials      114      113       -1     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `53.64% <0.00%> (+0.06%)` | :arrow_up: |
   | #javascript | `59.04% <100.00%> (+0.13%)` | :arrow_up: |
   | #python | `70.96% <88.09%> (+0.08%)` | :arrow_up: |
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/9753?src=pr&el=tree)
| Coverage Δ | |
   |---|---|---|
   | [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==)
| `66.66% <ø> (ø)` | |
   | [...rset-frontend/src/components/ErrorMessage/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL3R5cGVzLnRz)
| `100.00% <ø> (+100.00%)` | :arrow_up: |
   | [superset/views/datasource.py](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YXNvdXJjZS5weQ==)
| `93.33% <50.00%> (ø)` | |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5)
| `71.36% <50.00%> (-0.13%)` | :arrow_down: |
   | [...uperset-frontend/src/utils/getClientErrorObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3V0aWxzL2dldENsaWVudEVycm9yT2JqZWN0LnRz)
| `83.33% <100.00%> (+1.19%)` | :arrow_up: |
   | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==)
| `88.56% <100.00%> (ø)` | |
   | [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=)
| `87.96% <100.00%> (+0.17%)` | :arrow_up: |
   | [superset/errors.py](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXJyb3JzLnB5)
| `100.00% <100.00%> (ø)` | |
   | [superset/models/helpers.py](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2hlbHBlcnMucHk=)
| `87.95% <100.00%> (+0.06%)` | :arrow_up: |
   | [superset/views/base.py](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYmFzZS5weQ==)
| `72.35% <100.00%> (ø)` | |
   | ... and [22 more](https://codecov.io/gh/apache/incubator-superset/pull/9753/diff?src=pr&el=tree-more)
| |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9753?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/9753?src=pr&el=footer).
Last update [5d167af...d00f6dd](https://codecov.io/gh/apache/incubator-superset/pull/9753?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Mime
View raw message